Re: [PATCH v2] userdiff: add support for Swift

Johannes Sixt <[email protected]>
Newsgroups org.kernel.vger.git
Message-ID <[email protected]>
Am 27.07.26 um 07:03 schrieb Michael Montalbo:
> On Tue, Jul 21, 2026 at 12:06 AM Shlok Kulshreshtha <[email protected]> wrote:
>>
>> Add a built-in userdiff driver for the Swift programming language so that
>> diff hunk headers and word diffs work out of the box for ".swift" files.
>>
> 
> I noticed other languages add a test_language_driver entry to
> t/t4034-diff-words.sh with corresponding pre/post/expect
> fixtures. Should we add something similar for Swift?

We could that. But since the words are basically run-of-the-mill and
nothing exotic (like we had for the scheme driver), I gladly forgo a
test script at this time. In the past, these test scripts turned out to
be non-trivial to get correct and it was a burden for both the author
and the reviewers. It would certainly exceed the scope of a microproject.


-- Hannes
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.