Re: [PATCH v3] utf8: make utf8_strwidth() and utf8_strnwidth() return size_t
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Phillip Wood <[email protected]> writes: > I think it would be much better to remove the TODO comment as Junio > previously suggested and instead add some documentation to the function > explaining (a) why it is appropriate for it to return an int; (b) why we > must use the cast_size_t_to_int() helper to prevent overflows (see the > commit that added that comment). Thanks, especially for (b) above. That needs to be stressed if we are to go in that direction.