Re: [PATCH] submodule absorbgitdirs tests: use test_* helper functions
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Patrick Steinhardt <[email protected]> writes: > On Tue, Jun 30, 2026 at 11:00:28AM -0700, Junio C Hamano wrote: >> "Bryan B. Lima" <[email protected]> writes: >> >> > Use modern helper functions from test-lib-functions.sh to provide nice error messages. >> > >> > Signed-off-by: Bryan B. Lima <[email protected]> >> > Co-authored-by: Gustavo S. Correa <[email protected]> >> > Signed-off-by: Gustavo S. Correa <[email protected]> >> > --- >> > t/t7412-submodule-absorbgitdirs.sh | 22 +++++++++++----------- >> > 1 file changed, 11 insertions(+), 11 deletions(-) >> >> Welcome to the Git development community. > > Welcome indeed! > >> It is rare, but it happens from time to time, that we see a patch by >> somebody we haven't seen on this list, and the patch looks perfect. >> Very delighted. > > Sorry to spoil it: the order of SOBs is incorrect. The patch is authored > by Bryan, so that signoff needs to come last. > > The patch itself looks good though, thanks! This discussion thread has been hanging for a while after we saw this message. To help a new participant, here are a few tips. * These discussions can be seen on mail archives. On the primary archive, the message I am responding to appears here: https://lore.kernel.org/git/[email protected]/ For any discussion you are interested in, replace the URL path with the Message-Id of the message that is part of the discussion. For example, after sending a patch, you use the message ID of the patch message you sent out and by visiting the page there, you see everything people said on your patch. https://lore.kernel.org/git/[email protected]/ Scroll down to see the "Thread overview". * When you receive a review response to help you polish your patch submission, you are expected to respond to it. If the reviewer suggested an improvement, either you respond explaining why your original is better without the change suggested, or you respond thanking the reviewer for the suggestion and promise to submit an updated version that incorporates the suggested improvements, and then take your time to improve the patch and send a "reroll". For this patch, it would be numbered "v2". As we can see, neither option has occurred, and this discussion thread is keeping everybody waiting. Thanks.