Re: [PATCH v3] utf8: make utf8_strwidth() and utf8_strnwidth() return size_t
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
"Hardik Kumar" <[email protected]> writes: > On Mon Jul 27, 2026 at 8:25 PM IST, Junio C Hamano wrote: >> Phillip Wood <[email protected]> writes: >> >>> I think it would be much better to remove the TODO comment as Junio >>> previously suggested and instead add some documentation to the function >>> explaining (a) why it is appropriate for it to return an int; (b) why we >>> must use the cast_size_t_to_int() helper to prevent overflows (see the >>> commit that added that comment). >> >> Thanks, especially for (b) above. That needs to be stressed if we >> are to go in that direction. > > Should this be documented in a new adoc file in the technical > documentation directory? The best thing for the new comment to do is to replace the misguided TODO comment that led us to this exercise.