Re: [PATCH 1/3] urlmatch: normalize ssh and ftp default ports
Fabian Pottbäcker <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
> On 24. Jul 2026, at 13:35, Ben Knoble <[email protected]> wrote: > > Just offhand, not commenting on the rest of the series : the comments look wrong for ftp, ssh to me. Right, I messed up the continuation indent here (I wanted to make it in line with the rest of the file). Lined up for a v2, but it is minor so I would await further comments for now (see https://gitlab.com/fpottbaecker/git/-/compare/config_url_scp_syntax_v1..config_url_scp_syntax). Also, since I noticed this as a convenience thing gitgitgadget does: Fetch-It-Via: git fetch https://gitlab.com/fpottbaecker/git.git config_url_scp_syntax_v1