Re: [PATCH v2] pack-bitmap: handle objects at bitmap position zero

Taylor Blau <[email protected]> Tue, 28 Jul 2026 18:31:49 -0500
Newsgroups org.kernel.vger.git
Message-ID <amk75SuhyHBbx-E8@com-79390>
On Tue, Jul 28, 2026 at 03:46:39PM -0700, Junio C Hamano wrote:
> David Lin <[email protected]> writes:
>
> > `bitmap_position()` only returns a negative value when an object is not
> > present in the bitmap index.
> > ...
> > Also cover the non-pseudo-merge case by passing `HEAD` twice. The first
> > occurrence initializes the base from its stored bitmap, and the second
> > must recognize that position zero is already present.
> >
> > Helped-by: Taylor Blau <[email protected]>
> > Signed-off-by: David Lin <[email protected]>
> > ---
> > Changes since v1:
> > - Clarify the bitmap disk load wordings.
> > - Add coverage for the non-pseudo-merge case.
>
> Thanks, both of you.  Will queue.

This version looks good to me.

Thanks,
Taylor