Re: [PATCH] cat-file: handle content request for --batch-command without type

Alan Stokes <[email protected]> Wed, 29 Jul 2026 11:03:34 +0100
Newsgroups org.kernel.vger.git
Message-ID <CAFZW3h2hVMaVy12uO_5k5cwN=N9LDhrxuVSQPNmPWxB4j+kRwQ@mail.gmail.com>
On Tue, 28 Jul 2026 at 18:36, Junio C Hamano <[email protected]> wrote:
>
> Jeff King <[email protected]> writes:
>
> > We can fix it by tweaking the object_info on the fly as we receive each
> > command. But we should be careful to restore it afterwards; otherwise a
> > sequence of commands like:
> >
> >   contents $one
> >   info $two
> >   info $three
> >
> > will pay the type-lookup price for $two and $three when it does not need
> > to. This wouldn't be incorrect, but just slightly inefficient (and hence
> > there are no tests for that part, because the externally-visible
> > behavior is the same).
>
> Woooo, tricky.  I love this kind of attention to details.
>
> The patch text obviously is correct.
>
> Will queue and mark the topic for 'next'.  Thanks.

Thanks, Peff and Pablo. Sorry I wasn't able to contribute this time.

(Peff: for some reason I'm not receiving emails from you, although
I've got the other ones on this thread. I'm assuming that's due to
some over-zealous filter at my end.)

Best wishes,

Alan