Re: What's cooking in git.git (Jul 2026, #12)
Junio C Hamano <[email protected]> Wed, 29 Jul 2026 07:18:35 -0700
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Phillip Wood <[email protected]> writes: >> The experimental 'git history' command has been taught a new 'squash' >> subcommand to fold a range of commits into a single commit, with any >> descendants replayed on top. >> >> Will merge to 'master'. >> cf. <[email protected]> >> cf. <[email protected]> >> source: <[email protected]> > > Oh, I'd missed this going into master. Has the implementation received > any serious review? I've seen messages from a couple of people trying it > out but I can't see anybody reading the code. Thanks for stopping me. I am happy to immediately revert the merge of this topic into 'next'. Perhaps I should re-evaluate the "What's Cooking" report and eject other topics from 'next' as well. There are indeed topics I did not personally read, relying instead on impressions from busy exchanges (including earlier iterations read by others X-<). Are there other topics in 'next' that do not deserve to be there yet? I cannot, of course, afford to be the sole serious reviewer and merge only those I have carefully read through, given that there are only 24 hours in a day and I have other obligations. So either our quality criteria must suffer, like this episode showed us, or more topics must be ignored. > Having a quick look > through it assumes the presence of an UNINTERESTING commit means we have > a BOTTOM commit. It then assumes that UNINTERESTING commit means we > cannot reach any root commits. Both of those assumptions are false I > think. Very true. > ... I'll try and go through the patches and produce some fixups, > though that may not be until next week. Thanks.