Re: [PATCH GSoC 1/5] protocol-caps: add type support to object-info

Chandra Pratap <[email protected]> writes:

>>                 if (get_oid_hex_algop(oid_str, &oid, r->hash_algo) < 0) {
>>                         packet_writer_error(
>>                                 writer,
>> -                               "object-info: protocol error, expected to get oid, not '%s'",
>> +                               "object-info: protocol error, expected to get "
>> +                               "oid, not '%s'",
>
> I assume this is a style change? The original line doesn't seem
> long enough to wrap though.

A 92-column line is much wider than our usual ~70 column limit.

> Also, this would break the grep-ability of this error string.

I've heard this a few times, but so what?  You can still grep for
"object-info: protocol error," and will find it just fine.

>> +       cat >expect <<-EOF &&
>> +       size
>> +       type
>> +       $(git rev-parse two:two.t) $(wc -c <two.t | xargs) blob
>> +       $(git rev-parse two:two.t) $(wc -c <two.t | xargs) blob
>
> Can we not use the `test_file_size` tool to do this instead?
> That should also be much more portable.

Well spotted.