Re: What's cooking in git.git (Jul 2026, #12)

On Wed Jul 29, 2026 at 10:18 AM EDT, Junio C Hamano wrote:
> Phillip Wood <[email protected]> writes:
>
>>>   The experimental 'git history' command has been taught a new 'squash'
>>>   subcommand to fold a range of commits into a single commit, with any
>>>   descendants replayed on top.
>>> 
>>>   Will merge to 'master'.
>>>   cf. <[email protected]>
>>>   cf. <[email protected]>
>>>   source: <[email protected]>
>>
>> Oh, I'd missed this going into master. Has the implementation received 
>> any serious review? I've seen messages from a couple of people trying it 
>> out but I can't see anybody reading the code.

I believe I was one of the last people to comment on it.  I _had_ done a
read through of the code, spotted some things, but appear to have
missed these more nuanced interactions.  My last "lgtm" message in the
thread really meant to say "these latest fixes sufficiently address my
comments".  And as someone who doesn't have much history on the mailing
list, I assumed Junio would weigh my approval accordingly :)

I didn't notice this had advanced to next either, and may have spoken up
sooner if I did.

So given all that, assuming I had come along and looked at these
patches, but found no issues in the first place, I probably would have
stayed silent.  Should I be more careful with such a blanket "this is
good" message in the future?

Sorry for any hassle - though I don't expect you "blame" reviewers for
this sort of thing.  It's a lot harder to demonstrate correctness than
point out some potential problem.