Re: [PATCH] trace2: tolerate failed timestamp formatting

Junio C Hamano <[email protected]> Fri, 31 Jul 2026 08:57:01 -0700
Newsgroups org.kernel.vger.git
Message-ID <[email protected]>
Derrick Stolee <[email protected]> writes:

> * Taylor's hunch that the memory allocation is more likely at fault
>   is seeming more and more correct. When we fixed this issue, other
>   issues around memory allocation came to light.
>
> * For that reason, I'll rework this patch to point at the allocation
>   as the likely reason the parsing fails. Avoiding a die() in the
>   tracing code is still critical.
>
> * Thus, I'll also replace the xstrdup() in the trace code to avoid a
>   die() due to allocation problems.
>
> * I will take a deeper look at this wrapper change and how it might
>   be done in a careful way, as Taylor says his patch was an example
>   only and not the "right" way to do it.

Thanks.