Re: [PATCH 1/1] t7528: fix failure under csh

"brian m. carlson" <[email protected]> writes:

>> @@ -82,7 +82,7 @@ test_expect_success GPGSSH 'create signed commits' '
>>  test_expect_success GPGSSH 'sign commits using literal public keys with ssh-agent' '
>>  	test_when_finished "test_unconfig commit.gpgsign" &&
>>  	test_config gpg.format ssh &&
>> -	eval $(ssh-agent -T || ssh-agent) &&
>> +	eval $(ssh-agent -T -s || ssh-agent -s) &&
>>  	test_when_finished "kill ${SSH_AGENT_PID}" &&
>>  	test_when_finished "test_unconfig user.signingkey" &&
>>  	mkdir tmpdir &&
>
> This seems reasonable.  SHELL is defined by POSIX as "a pathname of the
> user's preferred command language interpreter."  When we're running the
> testsuite, we don't care what that is and always want a POSIX
> sh-compatible output, so using `-s` is the right thing.
>
> I also don't see any other instances of `ssh-agent` in the codebase, so
> this looks like the only place we need to fix.

Thanks for being careful.  Will queue.