Re: [PATCH 4/5] odb/source: introduce function to map source type to name

On Sun, Jul 26, 2026 at 01:34:17PM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <[email protected]> writes:
> 
> > Introduce a new function that maps an object source's type to a
> > human-readable name. Use the function to provide better human-readable
> > error messages for the downcasting functions.
> >
> > Signed-off-by: Patrick Steinhardt <[email protected]>
> > ---
> >  odb/source-files.h    |  4 +++-
> >  odb/source-inmemory.h |  4 +++-
> >  odb/source-loose.h    |  4 +++-
> >  odb/source-packed.h   |  4 +++-
> >  odb/source.c          | 19 +++++++++++++++++++
> >  odb/source.h          |  6 ++++++
> >  6 files changed, 37 insertions(+), 4 deletions(-)
> 
> OK.
> 
> > +static const char * const odb_source_names_by_type[] = {
> > +	[ODB_SOURCE_UNKNOWN] = "unknown",
> > +	[ODB_SOURCE_FILES] = "files",
> > +	[ODB_SOURCE_LOOSE] = "loose",
> > +	[ODB_SOURCE_PACKED] = "packed",
> > +	[ODB_SOURCE_INMEMORY] = "inmemory",
> > +};
> 
> This is a trivially obvious implementation for mapping in either
> direction.
> 
> 'inmemory' should probably be spelled 'in-memory', though.

Fair, that reads better indeed. Will adapt.

Patrick