Re: [PATCH GSoC v4 3/9] fetch-object-info: pass arguments directly instead of a struct

Pablo Sabater <[email protected]> writes:

> struct object_info_args groups three pointers that already live in the
> transport and are given to fetch_object_info().
> Grouping them into a struct reduces the number of parameters, but it
> suggests that the three belong together, when they are unrelated and end
> up being accessed as args->* independently.
>
> Drop the struct and pass those parameters directly to
> fetch_object_info() and send_object_info_request(). This should have no
> change in behavior.
>
> Helped-by: Jeff King <[email protected]>
> Helped-by: Junio C Hamano <[email protected]>
> Mentored-by: Karthik Nayak <[email protected]>
> Mentored-by: Chandra Pratap <[email protected]>
> Signed-off-by: Pablo Sabater <[email protected]>
> ---
>  fetch-object-info.c | 53 +++++++++++++++++++++++++++++++----------------------
>  fetch-object-info.h | 17 ++++++++---------
>  transport.c         | 11 +++++------
>  3 files changed, 44 insertions(+), 37 deletions(-)

OK, in this iteration, the step is truly about just getting rid of
the intermediate "args" structure and passing these three things
separately, without any other changes like the (half) addition of
"type" support like the previous iteration had.