Re: [PATCH v10 3/5] history: add squash subcommand to fold a range

Harald Nordgren <[email protected]> writes:

> Hi Phillip and Junio!
>
> I admit I’m trying to expedite the process. Especially given what
> feels like endless review cycles, and some frustration that this topic
> was queued for ’master’ and now it feels like we’re miles away again.
> I recognize that this mindset is not a good collaborative attitude, so
> I’ll try to step back and re-adjust my mindset.
>
> I am used to a work process where moving fast is paramount, and good
> enough is good enough in terms of code quality. I’m not seeing a
> healthy code review process here — any feedback halts the process
> completely. Should it really take months to merge a topic?

When you reroll too fast without waiting for reviewers, it
invalidates almost-done-but-yet-unpublished reviews.  If you
repeatedly do so, it exacerbates the problem by discouraging
reviewers from even looking at your topic, as they wonder if a
rapid reroll will invalidate their reviews yet again.

If it is taking months, I suspect that half of that is due to your
rapid rerolls, which have discouraged people from engaging, as they
cannot make a time commitment to a bottomless time sink.  The summer
being a relatively slow season certainly has played a role, too.

Thanks.