[PATCH v2 09/12] diff: widen `deflate_it()`'s bound local from int to `size_t`
"Johannes Schindelin via GitGitGadget" <[email protected]> Wed, 05 Aug 2026 16:14:36 +0000
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <ff103a0ee1f99f70b4d7110dc41c184cfd053703.1785946479.git.gitgitgadget@gmail.com> |
From: Johannes Schindelin <[email protected]> Fixes a pre-existing silent narrowing from `git_deflate_bound()`'s `unsigned long` return into an `int` local: anything past 2 GiB has always wrapped negative here and then been re-extended to `size_t` inside `xmalloc()`. Also prep for the upcoming `git_deflate_bound()` widening to `size_t`, which would extend the narrowing further if `bound` stayed `int`. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <[email protected]> --- diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diff.c b/diff.c index 69eb2f76a4..c14f69719b 100644 --- a/diff.c +++ b/diff.c @@ -3609,7 +3609,7 @@ static unsigned char *deflate_it(char *data, unsigned long size, unsigned long *result_size) { - int bound; + size_t bound; unsigned char *deflated; git_zstream stream; struct repo_config_values *cfg = repo_config_values(the_repository); -- gitgitgadget