Re: [PATCH v2 01/12] diff-delta: widen `struct delta_index`' size fields to `size_t`

Patrick Steinhardt <[email protected]> Thu, 6 Aug 2026 08:15:20 +0200
Newsgroups org.kernel.vger.git
Message-ID <[email protected]>
On Wed, Aug 05, 2026 at 04:14:28PM +0000, Johannes Schindelin via GitGitGadget wrote:
> diff --git a/delta.h b/delta.h
> index eb5c6d2fdb..ab0279168c 100644
> --- a/delta.h
> +++ b/delta.h
> @@ -28,7 +28,7 @@ void free_delta_index(struct delta_index *index);
>   *
>   * Given pointer must be what create_delta_index() returned, or NULL.
>   */
> -unsigned long sizeof_delta_index(struct delta_index *index);
> +size_t sizeof_delta_index(struct delta_index *index);
>  
>  /*
>   * create_delta: create a delta from given index for the given buffer

Okay. At this point in time there's still at least one caller that
assigns the result of `sizeof_delta_index()` to an `unsigned long`. But
at the end of the series all callers assign to a `size_t`.

Patrick