Re: [PATCH v2 1/3] environment: simplify repository config getters

On 8/7/26 00:50, Junio C Hamano wrote:
> Tian Yuchen <[email protected]> writes:
> 
>> Drop unnecessary parentheses and NULL checks in repository config
>> getters.
>>
>> These getters are only used with non-NULL repositories, so the
>> extra checks do not match their current callers.
> 
> You would need to explain why it is sensible to enforce on future
> callers the same rule that current callers honor, or why it is
> unlikely that we will gain any more callers in the future (which
> would justify catering only to current callers).
> 
>> Mentored-by: Christian Couder <[email protected]>
>> Mentored-by: Ayush Chandekar <[email protected]>
>> Mentored-by: Olamide Caleb Bello <[email protected]>
>> Signed-off-by: Tian Yuchen <[email protected]>
>> ---
>>   environment.c | 18 +++++++++---------
>>   1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/environment.c b/environment.c
>> index 76ee65e62b..f5628b6758 100644
>> --- a/environment.c
>> +++ b/environment.c
>> @@ -119,23 +119,23 @@ int is_bare_repository(struct repository *repo)
>>   
>>   int repo_protect_ntfs(struct repository *repo)
>>   {
>> -	return (repo && repo->initialized) ?
>> -		repo_config_values(repo)->protect_ntfs :
>> -		PROTECT_NTFS_DEFAULT;
>> +	return repo->initialized
>> +		? repo_config_values(repo)->protect_ntfs
>> +		: PROTECT_NTFS_DEFAULT;
>>   }
>>   
>>   int repo_protect_hfs(struct repository *repo)
>>   {
>> -	return (repo && repo->initialized) ?
>> -		repo_config_values(repo)->protect_hfs :
>> -		PROTECT_HFS_DEFAULT;
>> +	return repo->initialized
>> +		? repo_config_values(repo)->protect_hfs
>> +		: PROTECT_HFS_DEFAULT;
>>   }
>>   
>>   int repo_ignore_case(struct repository *repo)
>>   {
>> -	return (repo && repo->initialized) ?
>> -		repo_config_values(repo)->ignore_case :
>> -		0;
>> +	return repo->initialized
>> +		? repo_config_values(repo)->ignore_case
>> +		: 0;
>>   }
>>   
>>   int repo_trust_executable_bit(struct repository *repo)

I see, will change the commit message then ;)

Thanks, yuchen