Re: [PATCH v7 04/10] t6099, t6600: add side-exhaustion regression tests
Kristofer Karlsson <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <CAL71e4O6gyc_DSX40AEUOxyv4zCxtW4wdiJzwG6zaJbRS9Q39A@mail.gmail.com> |
On Fri, 7 Aug 2026 at 05:01, Elijah Newren <[email protected]> wrote: > > > +Graph shape (parents are below children): > > + > > + A ----------- X > > + |\ /| > > + | B---------/ | > > + | | | > > + e2 \ f2 > > + | | | > > + e1 d1 f1 > > + \ | / > > + \ | / > > + \| / > > + C > > + > > +A and X are the two tips. > > +B and C are both reachable from A and X. > > +B reaches C through d1. > > +Only B should appear in merge-base --all output. > > Was this graph created in an editor using a variable width font? In a > fixed width font, it makes one assume that C is not an ancestor of X, > but instead that C and f1 will likely eventually converge on common > history. One might need to know what your original variable width > font was in order to see it right. The description below if very > helpful, but could we replace the graph with: > > A ----- X > |\ /| > | B---/ | > | \ | > e2 \ f2 > | | | > e1 d1 f1 > \ | / > \ | / > \|/ > C > > ? I don't _quite_ remember how my ascii art ended up in this shape, I must have either have corrupted it along the way, or I considered it good enough to illustrate it even if does not look fully connected. The graph topology originally came from Stolee's counter-example in the original discussion thread but it looked prettier there. Regardless, I will try to clean it up for v8, perhaps by copying your suggestion verbatim. Thanks, Kristofer