Re: [PATCH v7 05/10] commit-reach: add trace2 instrumentation to paint_down_to_common()
Kristofer Karlsson <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <CAL71e4MDRGWeKsmKsRhyFsSBT8+QKbiGZ7+AydRk_Zxb2arn-Q@mail.gmail.com> |
On Fri, 7 Aug 2026 at 17:49, Elijah Newren <[email protected]> wrote: > > I think a short comment in the commit message about the new tests in > this commit triggering the existing min_generation optimization would > have dispelled my original misunderstanding and made the review > easier, and would thus be worthwhile to add for other reviewers or > future folks running across the commit. Agreed -- I was initially thinking about adding a comment in the test itself but adding it to the commit message makes a lot more sense. Will fix. Thanks, Kristofer