Re: [GSoC PATCH v3 0/7] repack: add --drop-filtered to reclaim space in partial clones
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Siddharth Shrimali <[email protected]> writes: > On Fri, 7 Aug 2026 at 03:49, Junio C Hamano <[email protected]> wrote: >> Have these patches been reviewed and tested? Is this a new breakage >> in v3? >> >> I think the accumulated fixes so far I have are as follows, but I >> suspect they need to be split and squashed into multiple patches (I >> didn't check). > sorry for the trouble, these are my mistakes: i ran t7706 but not the full > test suite, so i missed the t0450 SYNOPSIS check and the lint errors. > The -h usage string wasnt updated to match the new .adoc synopsis, > and i left a bare grep in the test. I'll fix all three, before sending a v4 Please do not limit yourself to "all three". Do not expect reviewers to be exhaustive. You are expected to be. IOW, do not just run a selected few tests. Run the full testsuite, and then some more, like making a trial merge to 'next' and to 'seen' and run full testsuite on the results. Thanks.