Re: [PATCH v2 07/12] fast-import: introduce 'struct fast_import_state'

On Tue, Aug 4, 2026 at 3:04 AM Christian Couder
<[email protected]> wrote:
>

> -static void note_change_n(const char *p, struct branch *b, unsigned char *old_fanout)
> +static void note_change_n(struct fast_import_state *state, const char *p, struct branch *b, unsigned char *old_fanout)

A really minor comment, but you've taken several lines (some of which
were already too long) and made them much too long.  This wasn't the
first or the last, but at 118 columns it was particularly far from the
80 characters per line guideline.  Could we change to

static void note_change_n(struct fast_import_state *state,
              const char *p,
              struct branch *b,
              unsigned char *old_fanout)

?

The actual substance of the patch looks good.