Re: [PATCH v4 00/11] doc: interpret-trailers: explain key format
"Kristoffer Haugsbakk" <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 6, 2026, at 13:55, D. Ben Knoble wrote: > Hi Kristoffer, > > Apologies for not returning to this for a while! I haven't read the > whole v4 in detail, but I reviewed the final diff and output. Your reviews, in whatever timeframe, are very much appreciated. > On Thu, Jul 30, 2026 at 5:18 AM <[email protected]> wrote: >>[snip] > > A few places we use an inline list syntax ("… (i) stuff … (ii) more > stuff …"). In the added example about ASCII trailers it is useful > because we make reference to (ii); in the initial part of the manual, > I don't see any references to the delimited items, so I'm not sure if > it's worth numbering them. I did adopt that Roman numeral inline list style for the example based on the existing one. I’ve always read it as a stylistic choice. So not for the ability to reference them. You have that ability, but I have the impression that most inline lists like that are not used to reference back to the item. This existing inline list goes back long before this series. Changing it would mean adding another change to an already long series. And I’m not sure that it should be changed in the first place. So for now at least I am not going to pick up on this topic. I will wait at least a day for any more comments and post a new version with that fix to the commit message. > >[snip]