Re: [PATCH 1/8] t: fix races caused by background maintenance

On 10.08.26 07:20, Patrick Steinhardt wrote:

> Git commands should just work with concurrent maintenance, and if they
> don't then it's worth to have a deeper look at why it doesn't.

That was my point; in lazygit's test suite I was getting errors when
executing simple commands such as "create a bunch of files, git add,
git commit". I had cases where the commit fails with

  error: invalid object 100644 50d5612... for 'file09.txt'
  error: Error building trees

> The reason why it's not fine for the Git test suite is that in lots of
> cases we assume a lot about the on-disk state of the repository. We are
> often reaching into internals to verify that it looks as expected, and
> that is of course racing with concurrent maintenance.

Yes, I understand why git's test suite has reasons to disable concurrent
maintenance. My point was that lazygit doesn't have any such reasons,
and shouldn't have to disable maintenance just so that the commands it
invokes don't error.

Stefan