Re: [PATCH 1/8] t: fix races caused by background maintenance
Patrick Steinhardt <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 10, 2026 at 09:37:01AM +0200, Stefan Haller wrote: > On 10.08.26 07:20, Patrick Steinhardt wrote: > > > Git commands should just work with concurrent maintenance, and if they > > don't then it's worth to have a deeper look at why it doesn't. > > That was my point; in lazygit's test suite I was getting errors when > executing simple commands such as "create a bunch of files, git add, > git commit". I had cases where the commit fails with > > error: invalid object 100644 50d5612... for 'file09.txt' > error: Error building trees That's a bug then that we ought to fix. Do you maybe have a reproducer for this? Also, which version of Git are you testing this with? We recently had an issue with multiple concurrent git-maintenance(1) processes running at the same time, which is something that shouldn't ever happen. That was fixed already, but IIRC Git 2.54 was still prone to this race. Patrick