Re: [PATCH v2] send-email: clarify missing subject error
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
"Harald Nordgren via GitGitGadget" <[email protected]> writes: > +test_expect_success $PREREQ 'missing subject omits Perl location' ' > + cat >no-subject.patch <<-\EOF && > + This is the body. > + EOF > + test_must_fail git send-email \ > + --dry-run \ > + --from="Example <[email protected]>" \ > + [email protected] \ > + no-subject.patch 2>actual && > + cat >expect <<-\EOF && > + No '\''Subject:'\'' line in '\''no-subject.patch'\'' > + EOF OK. We require the message to exactly be this one (not starting with this substring), which makes sure we are not getting the line numbers from die. Good. Will queue. This round looks perfect. Let's mark it for 'next'. Thanks.