Re: [PATCH GSoC v6 06/10] transport: drop remote object-info fields from transport struct
Karthik Nayak <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <CAOLa=ZTrf_WHiRHTjBGAus+YbRsUkbR3dzsW=fgCK0jit6fYzQ@mail.gmail.com> |
Chandra Pratap <[email protected]> writes: > On Sat, 8 Aug 2026 at 21:51, Junio C Hamano <[email protected]> wrote: >> >> Pablo Sabater <[email protected]> writes: >> >> > Rather than take these as function parameters, we take only the >> > transport object, and expect the caller to have placed the other two >> > into special fields in the transport struct. But this doesn't make much >> > sense. The set of oids and results are really only valid for one >> > request. There is no reason the transport would need to hang on to them >> > outside of the single function call. >> >> Thanks for injecting some sanity into the mix. >> >> With this fixed, are we happy with the entire series by now? > > Just went through the series and everything looks good to me, but I've had > the same opinion for the last couple of iterations as well. > > Thanks, > Chandra. Same. This version looks good to me too :)
signature.asc
(application/pgp-signature, 690 B)
-----BEGIN PGP SIGNATURE----- iQHKBAEBCgA0FiEEV85Mf2N1cQ/LZcYGPtWfJI5GjH8FAmp60o0WHGthcnRoaWsu MTg4QGdtYWlsLmNvbQAKCRA+1Z8kjkaMf3GJC/4y1FMVVO/UZpeKmMtFxtwYGAxW NXochoymGTNNXzvuqCdqJBwvfFzyshn0R8CnJy5pl/aJYsUnfYDU8PnWG74IeOaC i61JCgb7l4/o88qoEUws1muOtB2lsSDXJaSkcf1sKhgTm5dE+heyKIidl0kTs7YG pYh94mWqhiHQCtze7oVNv3CJdJNCQgciFk11KY4WiVJthUJTiJRNPE+dVcRTsBLc 4nPnbjRZRH0iZ/KDu+MToL4T3unPbMY5GEXh8OkW4wXGWgGlqId8pomBTx7fjc/9 0LvHTUZOIOi4NrCKh/qkj9yNjWI53QxzirqF4UG77CfQucvzxtwigkFcMqX9jW92 cArO0c/iXLnRj8XXG5tld+EcL8VmSvKm8Sa5A8zGtCtoqAPl/CACtvF8pOxCdzLR vywxA8W0mHckrO3IGbGKmx4IH0/JOgl+1jb28of8hEGPX0wrbo5zYjmV4GYsIfIs 9keoVx/o55BOpaThjOg3TE/7cyNW5jDrhBeWeho= =thib -----END PGP SIGNATURE-----