Re: [PATCH v2 0/8] odb: unify read and write streams

On Tue, Aug 11, 2026 at 06:13:05AM -0400, Karthik Nayak wrote:
> Patrick Steinhardt <[email protected]> writes:
> 
> > Hi,
> >
> > we have two different kind of object database streams in our code base:
> > `odb_write_stream` and `odb_read_stream`. While those are used for
> > different use cases, the provided functionality is ultimately the exact
> > same.
> >
> > This patch series thus refactors these streams so that we have a single
> > `odb_stream`, only. This allows us to reuse the streams for different
> > kinds of purposes and makes them more generally useful overall. For
> > example, it's trivially possible now to create an object stream for any
> > given object and then write that stream into a different source.
> >
> > The series is built on top of 5b2471720c (The 10th batch, 2026-08-03).
> >
> > Changes in v2:
> >   - Use the correct object type when hashing in-memory objects.
> >   - Remove a stale comment.
> >   - Adapt a commit message to mention that renames will follow in
> >     subsequent commits.
> >   - Add another commit to rename `struct input_zstream_data`.
> >   - Link to v1: https://patch.msgid.link/[email protected]
> >
> 
> I went through v2 and I think its already in a good state!

Thanks for your review!

Patrick