Re: [GSoC PATCH v4 0/7] repack: add --drop-filtered to reclaim space in partial clones

Siddharth Shrimali <[email protected]> writes:

> Changes since v3:
>   * fixed the git repack -h usage string to include --drop-filtered and
>     --dry-run, so it matches the SYNOPSIS in the documentation (t0450
>     was failing - caught by Junio)
>   * converted a bare grep in the test to test_grep (test-lint error -
>     caught by Junio)
>   * removed a stray bracket in the documentation SYNOPSIS

These three match what I locally fixed for the patches from the
previous iteration, so they are good.  I do not know if there needs
other changes to the patches, though.

> To do:
>   * remote verification: verifying against the remote awaits the
>     "remote-object-info" cat-file protocol command
>   * recency: a "don't cull recently-fetched objects" rule as another
>     selection criterion alongside size
>   * drop log: introduce with the error-path change that reads it

Are these "planned for longer term, material for separate sets of
patches to come on top, after this series graduates"?  Or do you
mean "v5 and later rounds need to do these three things before the
series can be called complete"?

Thanks.

>
> [1] https://lore.kernel.org/git/[email protected]/
>
> Siddharth Shrimali (7):
>   builtin/repack.c: add --drop-filtered and --dry-run options
>   list-objects-filter: add list_objects_filter__filter_oidset()
>   repack-promisor: allow excluding objects from the rebuilt promisor
>     pack
>   builtin/repack: enumerate promisor blobs for --drop-filtered
>   builtin/repack: actually drop filtered promisor blobs
>   builtin/repack: add guards for --drop-filtered
>   Documentation/git-repack: document --drop-filtered and --dry-run
>
>  Documentation/git-repack.adoc   |  37 +++++++
>  builtin/repack.c                | 151 +++++++++++++++++++++++++-
>  list-objects-filter.c           |  45 ++++++++
>  list-objects-filter.h           |  16 +++
>  repack-filtered.c               |  82 ++++++++++++++
>  repack-promisor.c               |  15 ++-
>  repack.h                        |   8 +-
>  t/meson.build                   |   1 +
>  t/t7706-repack-drop-filtered.sh | 185 ++++++++++++++++++++++++++++++++
>  9 files changed, 533 insertions(+), 7 deletions(-)
>  create mode 100755 t/t7706-repack-drop-filtered.sh