Re: [PATCH] gitk: add user-defined custom commands

Am 10.08.26 um 21:38 schrieb Tim Wiederhake:
> I think there may be a misunderstanding about what this patch does. I
> am not proposing "add an edit-file button to gitk." I am proposing "let
> users add their own commands to the context menus." The rebase+edit
> workflow was an example of what becomes possible. It is not the feature
> itself.

I totally understand that you are proposing a way to supply generic
commands, and I do not ask for something else, but I was a bit too terse
in what I said. I meant to say that you can use "invoke an editor" as
the justification for the generic command that is called from the diff
panel. And "git rebase" can be a justification for a generic command
called from the commit list. (These two kinds of commands should really
be added in separate steps, BTW.)

> Shipping it with only %f but not %i or %t would produce a half-useful
> extension system that nobody can actually use, existing only to satisfy
> the review process.

You already get something very useful with only the %f (filename)
substitution, because it can invoke an editor with a suitable file.

Do not underestimate the review process. Presenting the features in
digestible pieces is absolutely beneficial. The substitutions lend
themselves to be their own commits each (or in small groups per commit).

-- Hannes