Re: [PATCH] git: avoid segfault on "git --shallow-file" without a value
Patrick Steinhardt <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 11, 2026 at 02:14:46PM +0200, Christian Couder wrote:
> diff --git a/git.c b/git.c
> index e5f1811b6b..96df15b5cd 100644
> --- a/git.c
> +++ b/git.c
> @@ -304,11 +304,15 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
> if (envchanged)
> *envchanged = 1;
> } else if (!strcmp(cmd, "--shallow-file")) {
> - (*argv)++;
> - (*argc)--;
> - setenv(GIT_SHALLOW_FILE_ENVIRONMENT, (*argv)[0], 1);
> + if (*argc < 2) {
> + fprintf(stderr, _("no file given for '%s' option\n" ), "--shallow-file");
> + usage(git_usage_string);
Should we maybe condense this into a single line?
usage(_("no file given for '%s' option\n")), "--shallow-file")
I think that also printing the usage string is only distracting and
doesn't really give the user a lot of extra context.
Other than that this patch looks good to me, thanks!
Patrick