Re: [PATCH v3 00/12] coverity: fix unchecked returns
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
"Johannes Schindelin via GitGitGadget" <[email protected]> writes: > This is the next batch of fixes in response to issues reported by Coverity. > > Changes since v2: > > * Added a new commit to handle block-writer initialization errors (instead > of ignoring them). > * The bw->zstream attribute is now also deinitialized in the error case, as > suggested by Junio. > * The commit message of "reftable/block: check deflateInit() return value" > was rephrased to stop suggesting that silent corruption by zlib would be > possible before that patch: This turned out to be provably incorrect. > * When aborting the bisect because dup2() failed, a left-over saved_stdout > is now also cleaned up. Everything looks sensible. I am fine with declaring victory, but does anyone want to second it?