Re: [PATCH v8 00/10] commit-reach: terminate merge-base walk when one side is exhausted

Kristofer Karlsson <[email protected]> writes:

> ... and here I just restored your tests to their original glory,
> despite making the patch series as a whole feel a bit inconsistent.
>
> Overall though, I wonder if it would be useful to codify a
> preference for double or single spacing after periods, even if
> that (obviously) does not imply we should reformat the entire
> code-base directly.

This is a thing that is best left for "match the surrounding area"
rule.  As you mentioned earlier, it is not something we want to go
back and churn every line to make it consistent.

>> Okay, my last two range-diff comments were just jokes, but more
>> serious now: I think you did a nice job on the re-splitting.  Thanks
>> for doing that!
>
> Thank you, writing documentation feels harder (for me)
> than coding, but I'm somewhat happy with the end state now :)

Good.  We can declare victory and mark the topic for 'next' now?

Thanks, both of you.