Re: [PATCH v3 0/4] completion: add support for 'git history'

On 13/08/2026 at 22:30, Kristoffer Haugsbakk wrote:
> On Thu, Aug 13, 2026, at 21:05, Vincent Mailhol wrote:
>> This series adds Bash completion for the subcommands of "git history"
>> and their options.
>>
>> Patch #1 adds the basic subcommand and options completion. Patch #2 and
>>
>> options. Finally, Patch #4 adds completion for pathspecs accepted by
>> "split".
> 
> It looks like one line was accidentally deleted/blanked. But I think 
> it would say the same thing as on v2:
> 
> ---
> Patch #1 adds the basic subcommand and options completion. Patch #2
> and #3 take care of the value of the --empty and --update-refs options.
> Finally, Patch #4 adds completion for pathspecs accepted by "split".
> ---
> 
> Was the paragraph reflowed with 
> "#3" at the start and treated like
> a comment line?

Exactly.

This is the cover letter as I intended to send it:

  completion: add support for 'git history'
  
  This series adds Bash completion for the subcommands of "git history"
  and their options.
  
  Patch #1 adds the basic subcommand and options completion. Patch #2 and
  #3 take care of, respectively, the value of the --empty and --update-refs
  options. Finally, Patch #4 adds completion for pathspecs accepted by
  "split".
  
  For each of the completions, add a set of relevant test cases.

As you guessed, b4 removed the line starting with #3. I didn't see this
coming. From now on, I will stop using # in the description.

Should I send a v4 with the fixed cover letter, or is it OK as-is?


Yours sincerely,
Vincent Mailhol