Re: [PATCH v2 1/4] odb: decouple source path comparisons from `the_repository`

Patrick Steinhardt <[email protected]>
Newsgroups org.kernel.vger.git
Message-ID <[email protected]>
On Fri, Aug 14, 2026 at 01:21:13PM -0400, Jeff King wrote:
> On Wed, Aug 12, 2026 at 11:13:57AM +0200, Patrick Steinhardt wrote:
> 
> > Fix this by making the comparison self-contained in the object
> > database. Instead of using `fspathhash()` and `fspatheq()` we resolve
> > "core.ignoreCase" manually and then use the correct comparison function
> > based on the result. This requires us to migrate to a `struct hashmap`,
> > as the khash interface does not give us the ability to change these
> > functions.
> 
> By the way, this bit about khash confused me. We can provide whatever
> hash and equality functions we want. But I'm guessing maybe the issue is
> that in the khash function interface khash expects, there's no extra
> "void *" parameter you can use to store the bit to tell you whether to
> be case insensitive or not?

Ah, yes, that's in fact what I wanted to convey. I'll clarify that a
bit.

Patrick
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.