Re: [PATCH v2 1/4] odb: decouple source path comparisons from `the_repository`

On Mon, Aug 17, 2026 at 11:42:34AM +0200, Patrick Steinhardt wrote:

> > I think we have repo_ignore_case() now, since e6a79c9eb8 (config: use
> > repo_ignore_case() to access core.ignorecase, 2026-06-19). That's in
> > 'master', so it might be worth building on that instead. And then if
> > there's any cache invalidation to do, it would eventually happen there.
> 
> We can't use that one though, as it uses `repo_config_values()`, and
> that function only works with `the_repository`. So that'd break with
> submodule repositories.

Oh, wow. I looked at the function and saw that it took a repository
arguments. But then repo_config_values() does a BUG() when you pass in
anything but the_repository. That's...surprising. And gross.

But yeah, I agree it's not yet ready for your use here.

-Peff