Re: [PATCH v13 7/8] history: create squashed commits without editing
"Kristoffer Haugsbakk" <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Aug 17, 2026, at 19:38, Harald Nordgren wrote: >> >> Inspired-by: Sergey Chernov <[email protected]> >> >> Helped-by: Phillip Wood <[email protected]> >> >> Signed-off-by: Harald Nordgren <[email protected]> >> >> Thanks for the Helped-by: trailer, but this and several of the other >> patches are missing my sign off from the fixup patches I sent. My sign >> off should come above yours to reflect the chain of custody. > > Got it, should I use both headers? > > Helped-by: Phillip Wood <[email protected]> > Signed-off-by: Phillip Wood <[email protected]> > Signed-off-by: Harald Nordgren <[email protected]> In general swapping the first and second makes more sense. S: PW H: PW S: HN Because as a chain of custody this says: Phillip signed off, then Harald said that PW helped him, then Harald signed off on what he got from PW with perhaps his own changes mixed in. sent from mobile