Re: [RFC PATCH 0/1] config: surface editor failure in exit code

Karthik Nayak <[email protected]> writes:

> Wouldn't it be better to notify the user that something went wrong
> rather than simply brush it off?

If we were adding 'git config -e' today, absolutely.  The issue is
not the comparison between signaling with an exit code and not
doing so.  The question is whether the benefit or conceptual
correctness outweighs any possible downside of changing the
behavior existing users have grown accustomed to.

Having said that, 'git config -e' is relatively new, introduced in
commit 3cbace5ee0 (builtin/config: introduce "edit" subcommand,
2024-05-06).  The folks who may be affected are those who used
'git config -e' in their scripts and carefully checked the exit
status (or rather, lazily used 'set -e'), and did so in the past
two years.  So the fallout might not be so great.

So, I dunno.