Re: [PATCH v3 2/4] completion: complete 'git history --empty' values

Patrick Steinhardt <[email protected]>
Newsgroups org.kernel.vger.git
Message-ID <[email protected]>
On Thu, Aug 13, 2026 at 09:05:03PM +0200, Vincent Mailhol wrote:
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 1727768487..7f3cabd595 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2169,6 +2169,15 @@ _git_history ()
>  
>  	if ! __git_has_doubledash; then
>  		case "$cur" in
> +		--empty=*)
> +			case "$subcommand" in
> +			drop|fixup)
> +				__gitcomp "drop keep abort" "" \
> +					"${cur##--empty=}"
> +				;;
> +			esac
> +			return
> +			;;

It would've been fine to just do this for every subcommand, I guess. But
this version works for me, too.

Patrick
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.