[PATCH v2 0/1] config: surface editor failure in exit code
Kenneth Lorber <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
(Apologies to anyone who gets this twice.)
Simplified the tests and changed the test names from "--edit" to "-e"
since that's what the test is actually running. Did not change the
tests to use "--edit" as nothing else is checking "-e".
1: d54d260aa0 ! 1: 05d02b80dc config: surface editor failure in exit code
@@ t/t1300-config.sh: test_expect_success 'command line overrides environment config' '
test_cmp expect actual
'
-+test_expect_success 'git config --edit successful exit' '
++test_expect_success 'git config -e successful exit' '
+ test_when_finished "rm -rf repo" &&
+ git init repo &&
-+ GIT_EDITOR=true &&
-+ export GIT_EDITOR &&
-+ git -C repo config -e &&
-+ unset GIT_EDITOR
++ test_env GIT_EDITOR=true git -C repo config -e
+'
+
-+test_expect_success 'git config --edit failure exit' '
++test_expect_success 'git config -e failure exit' '
+ test_when_finished "rm -rf repo" &&
+ git init repo &&
-+ GIT_EDITOR=false &&
-+ export GIT_EDITOR &&
-+ test_must_fail git -C repo config -e &&
-+ unset GIT_EDITOR
++ test_env GIT_EDITOR=false test_must_fail git -C repo config -e
+'
+
test_expect_success 'git config --edit works' '
--
2.43.0