Re: [PATCH v3 0/4] completion: add support for 'git history'
Junio C Hamano <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <[email protected]> |
Patrick Steinhardt <[email protected]> writes: > On Thu, Aug 13, 2026 at 09:05:01PM +0200, Vincent Mailhol wrote: >> Changes in v3: >> >> - Ignore the split "<option> <value>" syntax for options that take >> arguments. This simplifies revision detection and avoids hard-coding >> option names. >> - Test that options are not completed before a subcommand. > > I'm happy with this version and I think it's a good base to build on > going forward. Thanks! > > Patrick Thanks, both. I'll prepare an evil-merge to rewrite the test to add 'squash' to the candidatesto adjust to the subcommand addition to another topic in-flight brings in when merging these patches to 'seen'. Vincent, this is strictly FYI. You do not need to rebase on top of the other topic, until I and/or the author of the other topic ask you. Thanks.