Re: [PATCH v3 6/6] bundle: generate packfiles via the object database

Karthik Nayak <[email protected]> Thu, 20 Aug 2026 07:19:45 -0400

Newsgroups	org.kernel.vger.git
Message-ID	<CAOLa=ZQ7-_=T1NSXY433oME8OoddJOuLX0wmdbk2ocQ0JTAuKQ@mail.gmail.com>

Patrick Steinhardt <[email protected]> writes:

> git-bundle(1) spawns git-pack-objects(1) directly to generate the pack
> data that gets appended to the bundle header. While bundles are not
> part of the wire protocol, they are a transfer mechanism for packs all
> the same, so convert them to use the pack generation interface of the
> object database as well.
>
> This makes the pack generator the single spawn point for all pack
> streams that leave the repository, leaving only local maintenance tasks
> like git-repack(1) with direct knowledge of git-pack-objects(1).
>
> Signed-off-by: Patrick Steinhardt <[email protected]>
> ---
>  builtin/bundle.c | 10 +-------
>  bundle.c         | 69 ++++++++++++++++++++++++++++----------------------------
>  bundle.h         |  3 +--
>  3 files changed, 37 insertions(+), 45 deletions(-)
>
> diff --git a/builtin/bundle.c b/builtin/bundle.c
> index bfafadc984..de86e092a6 100644
> --- a/builtin/bundle.c
> +++ b/builtin/bundle.c
> @@ -69,7 +69,6 @@ static int parse_options_cmd_bundle(int argc,
>
>  static int cmd_bundle_create(int argc, const char **argv, const char *prefix,
>  			     struct repository *repo UNUSED) {

This '{' should be on the next line, but that's not on you :)

[snip]

The rest looks good.

signature.asc (application/pgp-signature, 690 B)