Re: [PATCH v4 2/3] environment: align repo_config_values_init with struct declaration

On Thu, Aug 20, 2026 at 1:45 PM Junio C Hamano <[email protected]> wrote:
>
> "D. Ben Knoble" <[email protected]> writes:
>
> > The order of assignments in repo_config_values_init is chaotic and hard
> > to follow, especially when comparing with the struct definition to
> > ensure all members are initialized. As new members will be added in the
> > future, make it easier to validate changes by aligning the two.
> >
> > Refactor assignment order with no behavioral changes.
>
> After reading the above three times, I am tempted to slightly tweak
> the above:
>
>     ... comparing with the definition of 'struct repo_config_values' to
>     ensure ...
>
> Other than that, great improvement.
>
> Thanks.

Yep, that flows much better. Amended locally.

-- 
D. Ben Knoble