Re: [BUG] git config --global: doc and behaviour disagree when ~/.gitconfig and XDG config file coexist
Nils Fahldieck <[email protected]>
| Newsgroups | org.kernel.vger.git |
|---|---|
| Message-ID | <CAAdFe9z92-h8eQmwxzZ=1cCB_8ptTHKnL1QMWAO=VEJVHe07OQ@mail.gmail.com> |
Hi Delilah, thank you for chiming into this thread. I am very excited to be reading about your progress, patches and everything you've contributed so far. > Since then, I've addressed most of the review feedback. I have a draft > v2 series [4] almost ready for reroll. When you have the v2 of your patch ready, please let me know and I am happy to provide any feedback. I really like to see this change happening. Am Do., 13. Aug. 2026 um 08:07 Uhr schrieb Delilah Ashley Wu <[email protected]>: > > On Fri, Jul 31, 2026 at 09:14:07AM +1000, Ben Knoble wrote: > >> Le 31 juil. 2026 à 05:35, Junio C Hamano <[email protected]> a écrit : > >> Nils Fahldieck <[email protected]> writes: > >>> 2. The reading claim is outright wrong. > >>> > >>> The docs say --global reads from BOTH files. The code reads from > >>> ONE. git_global_config() selects a winner and frees the other > >>> path. There is no code path under --global that reads both files. > >> > >> The documentation needs to be corrected, I think. > > > > Agreed based on recent thread <[email protected]> > > (subject « git config: unintuitive behavior with - -global and - -no-includes » > > A previous thread [1] said this behavior could be a bug. So, last year, > I submitted a patch series [2] to align behavior with documentation, > changing `git config` to read from both files. We gave time for the > community to comment on whether we should change the behavior or the > documentation, but there weren't any strong opinions [3]. The only > responses were a correction to my cover letter and a technical review of > my patches. > > Since then, I've addressed most of the review feedback. I have a draft > v2 series [4] almost ready for reroll. I only work on it during "side > project time" [5] at my workplace, but I'll try to have v2 ready soon > for further discussion/review. > > [1] https://lore.kernel.org/git/[email protected]/ > [2] https://lore.kernel.org/git/[email protected]/ > [3] https://lore.kernel.org/git/[email protected]/ > [4] https://github.com/gitgitgadget/git/pull/2196 > [5] https://en.wikipedia.org/wiki/Side_project_time