Re: [patch hail 1/1] Plug leak in hstor_parse_key

Jeff Garzik <[email protected]> Wed, 19 Oct 2011 00:18:59 -0400
Newsgroups org.kernel.vger.hail-devel
Message-ID <[email protected]>
On 10/14/2011 01:34 PM, Pete Zaitcev wrote:
> Signed-off-by: Pete Zaitcev<[email protected]>
>
> ---
>   lib/hstor.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/hstor.c b/lib/hstor.c
> index cb9c4da..5ce9b76 100644
> --- a/lib/hstor.c
> +++ b/lib/hstor.c
> @@ -761,7 +761,7 @@ void hstor_free_keylist(struct hstor_keylist *keylist)
>   static void hstor_parse_key(xmlDocPtr doc, xmlNode *node,
>   			  struct hstor_keylist *keylist)
>   {
> -	struct hstor_object *obj = calloc(1, sizeof(*obj));
> +	struct hstor_object *obj;
>   	xmlChar *xs;

good catch... applied