Re: [Patch 1/2] CLD: export a common timer implementation

On 01/16/2010 02:07 AM, Pete Zaitcev wrote:
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index 68be429..dfae79a 100644
> --- a/lib/Makefile.am
> +++ b/lib/Makefile.am
> @@ -9,14 +9,14 @@ LINK = $(LIBTOOL) --mode=link $(CC) $(CFLAGS) $(LDFLAGS) -o $@
>
>   lib_LTLIBRARIES		= libcldc.la
>
> -libcldc_la_SOURCES	= cldc.c cldc-udp.c cldc-dns.c common.c
> +libcldc_la_SOURCES	= cldc.c cldc-udp.c cldc-dns.c common.c libtimer.c
>
>   libcldc_la_LDFLAGS = \
>   	-version-info $(LIBCLDC_CURRENT):$(LIBCLDC_REVISION):$(LIBCLDC_AGE) \
>   	-no-undefined \
>   	-export-symbols-regex "^[^_].*"
>
> -noinst_LIBRARIES	= libtimer.a
> +noinst_LIBRARIES	=
>
>   pkgconfigdir = $(libdir)/pkgconfig
>   pkgconfig_DATA = libcldc.pc


applied 1-2, and fixed some bugs:

* removed now-empty noinst_LIBRARIES

* libtimer.c functions were exported into the lib, but no header was 
made available, meaning they could not really be used outside CLD tree. 
  Folded libtimer.h into cld_common.h, which is installed on end-user 
systems.