Re: [PATCHv2] cld: use XDR for all messages

On Tue, Jan 26, 2010 at 2:11 PM, Jeff Garzik <[email protected]> wrote:
> Actually I poked at it this weekend, and was about to finish up.  So hold
> off for another day, if you would.
>
> The answer is, there are two different build environments to consider for
> headers:  the in-tree build environment, and the installed-header build
> environment.  That is why including "lib/foo.h" does not work, particularly
> in nested headers.  You need to fiddle INCLUDES in Makefile.am to get the
> header path correct at build time, and then ensure that all headers are
> installed in the proper location (by default, $includedir) using
> include_HEADERS.  That way, cld_msg_rpc* remains in lib/ while the other
> headers remain in include/

We should probably also add an AC_CHECK_PROG(rpcgen, ...) to configure.ac

On an unrelated note, I just discovered "make check". I feel kind of
silly that I didn't try that before. :)

>
> Also, while splitting this up, I noticed that ping_open is no longer set to
> true.

Good catch. Clearly session_timeout should be setting that to true
when it sends the PING message.

Colin