[PATCH] Re: [PATCHv2] cld: use XDR for all messages

On 01/29/2010 08:01 PM, Colin McCabe wrote:
> That seems reasonable. All of those functions could be looked at as "common."
>
> The intention was to group together a bunch of functions that were
> useful for packet formatting. Although the bulk of the formatting is
> done by XDR, there are some things that XDR doesn't do, like
> generating and checking SHA sums. cld_dump_buf and cld_pkt_hdr_to_str
> are purely for debugging purposes, but they seemed like something that
> would be generally useful for developers making packet format changes.
> I know that they were useful to me.


I finally pushed out several changes split off from your main XDR patch, 
to the upstream cld git repo.  It took longer than expected because I 
would make changes of my own along the way, which, each time, 
necessitated a rediff+rebuild between "current cld" working tree and 
"cld + xdr" working tree.

The attached patch is what remains to be split up and committed.  I have 
definitely whittled it down, and along the way, moved and renamed some 
things on my own.  With regards to cld_fmt.*, my main objection was to 
creating too many to-be-installed headers.  One more header can be a 
pain for us and for users, while one more source file in cld/lib/ is no 
big deal.

Thus, the intention is to eliminate cld_fmt.h (newly renamed to 
cld_pkt.h) altogether, while keeping the arrangement you created in 
cld_fmt.c (newly renamed to lib/pkt.c).

I will continue whittling down the patch until it just contains the XDR 
changes themselves.

	Jeff