Re: [Patch 1/1] CLD: regression in unified cld_timer
Jeff Garzik <[email protected]>
| Newsgroups | org.kernel.vger.hail-devel |
|---|---|
| Message-ID | <[email protected]> |
On 02/09/2010 12:02 PM, Pete Zaitcev wrote: > The common timer implementation had a bug whereas it overwrote the list > of timers when a timer callback added its own timer -- which just about > every one of them does. The most visible result was that sessions stopped > expiring correctly and left dangling file locks. Also, every new session > failed after 2 minutes 35 seconds. > > The fix is not to keep a local copy of the list head across invocations > of the callback. > > Signed-Off-By: Pete Zaitcev<[email protected]> > > --- > lib/libtimer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > Jeff& Colin: sorry to waste your time with inferences that the change > to XDR was somehow involved. I guess I did not update the CLD on the > server since before the common timer. applied