Re: [PATCHv2] cld: use XDR for all messages

On 02/09/2010 06:13 PM, Pete Zaitcev wrote:
> On Tue, 09 Feb 2010 04:38:21 -0500
> Jeff Garzik<[email protected]>  wrote:
>> On 02/09/2010 04:20 AM, Jeff Garzik wrote:
>
>>> Useful per-packet cld [the daemon] verbose output seems to have
>>> disappeared? Or did I miss a knob somewhere?
>>
>> cldcli no longers dumps per-packet debug info at maximum verbosity,
>> either.  Our built-in debug facilities have definitely regressed.
>
> I posted the patch for both server and client, which should fix it.
> Looks like we became confused about what the exact meaning for
> log.verbose is, since historically we had 2: one means
> "enable LOG_DEBUG" and the other "enable per-packet dumping"
> (which is really verbose in normal operation). So the patch
> splits the two, thus permitting cldcli to control verbosity
> precisely. And no more commented-out assignments.

Actually it should be as presented in "cld --help" and "cldcli --help": 
  an integer, whose increasing value indicates increasing verbosity. 
Higher values enable really verbose output, such as per-packet output.

So, the programs themselves have it right -- debug/verbose is an integer 
not a bool.  The internal libraries get that wrong sometimes, though.

Having separate knobs for 'debug' and 'verbose' will be more confusing 
than a single control, IMO.

	Jeff